client: consul hook not called for templates #19490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkazmierczak
added
type/bug
theme/consul
theme/workload-identity
backport/1.7.x
pkazmierczak
changed the title
pkazmierczak
changed the title
tgross
reviewed
Dec 15, 2023
tgross
approved these changes
Dec 15, 2023
pkazmierczak
deleted the
b-consul-wi-consul_hook_task_doesn_get_called
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some refactoring mishap, task-level Consul hook was never triggered and thus never wrote any secrets in task secret dirs.
Fixes #19488