Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fix a small regression where accessor is hidden by default when editing a token #19432

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

philrenaud
Copy link
Contributor

When editing or viewing a newly created token, we want the Accessor to be visible (and the secret masked).

The Helios masked input component recently changed the property for this from isMasked to isContentMasked, so updating it here to follow up our Helios upgrade:

image

@philrenaud philrenaud added the backport/1.7.x backport to 1.7.x release line label Dec 11, 2023
@philrenaud philrenaud requested a review from tgross December 11, 2023 16:29
@philrenaud philrenaud self-assigned this Dec 11, 2023
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Dec 11, 2023

Ember Test Audit comparison

main aafb4a2 change
passes 1540 1540 0
failures 0 0 0
flaky 0 0 0
duration 10m 50s 982ms 10m 51s 836ms +854ms

@philrenaud philrenaud merged commit b165401 into main Dec 11, 2023
15 checks passed
@philrenaud philrenaud deleted the b-ui/token-editor-unmasked-content branch December 11, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants