keyring: replicate RSA private key via GetKey RPC
#19350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added a RSA key for signing Workload Identities, we added it to the keystore serialization but did not also add it to the `GetKey` RPC. This means that when a key is rotated, the RSA key will not come along. The Nomad leader signs all Workload Identities, but external consumers of WI (like Consul or Vault) will verify the WI against any of the servers. If the request to verify hits a follower, the follower will not have the RSA private key and cannot use the existing ed25519 key to verify WIs with the `RS256` algorithm. Add the RSA key material to the `GetKey` RPC. Also remove an extraneous write to disk that happens for each key each time we restart the Nomad server. Fixes: #19340
tgross
force-pushed
the
b-gh13340-keyring-restore
branch
from
ca45772 to
a7345f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added a RSA key for signing Workload Identities, we added it to the keystore serialization but did not also add it to the
GetKeyRPC. This means that when a key is rotated, the RSA key will not come along. The Nomad leader signs all Workload Identities, and external consumers of WI (like Consul or Vault) will verify the WI using theKeyring.ListPublicRPC that's forwarded to the leader. After a leader election, the new leader will not have the RSA private key and cannot use the existing ed25519 key to verify WIs with theRS256algorithm.Add the RSA key material to the
GetKeyRPC.Also remove an extraneous write to disk that happens for each key each time we restart the Nomad server.
Fixes: #19340