Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC, move "arch" into "os." key for node Attributes #1930

Closed
jippi opened this issue Nov 3, 2016 · 2 comments
Closed

RFC, move "arch" into "os." key for node Attributes #1930

jippi opened this issue Nov 3, 2016 · 2 comments
Labels
stage/thinking theme/client

Comments

@jippi
Copy link
Contributor

jippi commented Nov 3, 2016

Today arch is kinda flowing out in the root key of Attributes in the API

I think it would make sense to move it into os.arch to group it logically with os.name and os.version
@dadgar
Copy link
Contributor

dadgar commented Nov 5, 2016

I think it may make sense to move it to cpu.arch since it is an attribute of the CPU actually

@dadgar dadgar added this to the v0.5.1 milestone Nov 10, 2016
@diptanu diptanu mentioned this issue Jan 6, 2017
Merged
@tgross tgross modified the milestones: near-term, unscheduled Jan 9, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage/thinking theme/client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jippi @dadgar @tgross