-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Title bar job start button now observes job submission variables data #19220
Conversation
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a minor inline comment; I also think we will need a changelog entry for this.
I tried testing this locally and I get the same error as the linked issue describes. I'm not sure if I am testing this wrong.
@jrasell I'm testing with the following jobspec (from your comment in the linked issue, I think):
and running with I'm able to get the "start" button to fire it back up with a count of 4 in the following ways:
In all of these cases, if you happen to go to the definition tab for the job, you should see the count in the variables box: |
8fe7339
to
6ef27b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Worth noting I think we will also now need the 1.7 backport label as that release branch is now live.
Resolves #19198
Previously, after stopping a job with variables passed in but no default values, going to the definition page and editing would work fine (as variable literals were already present on the page), but the "start" button would not consider them.
Now they're specifically checked when the job start button is pressed.
Side-effect: utility-ified the json-to-hcl method previously internal to the job editor component.