Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Show message for when log collection is disabled #18823

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

Sanskar531
Copy link
Contributor

@Sanskar531 Sanskar531 commented Oct 21, 2023

#16986
This is how it looks now:
https://imgur.com/a/i7XNgpY

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 21, 2023

CLA assistant check
All committers have signed the CLA.

@Sanskar531 Sanskar531 changed the title UI: Show message for when log collection is disabled (#16986) UI: Show message for when log collection is disabled Oct 21, 2023
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sanskar531! The approach you're using here looks good to me in terms of what scenario we're responding to. I'm going to tag in @juliezzhou to get her feedback on the visual design of this warning dialog.

Thanks for the PR!

@juliezzhou
Copy link

looks like there are 2 options based on https://imgur.com/a/i7XNgpY? I prefer the option that shows the alert on top of the code block. i think it is more consistent with the notification on other pages

@Sanskar531
Copy link
Contributor Author

Hey guys, sorry for the confusion. The notification you are seeing in my test plan are from two different places. It uses the same component but it appears differently because of responsive design I am assuming.

Here is the complete page:
https://imgur.com/a/B9pKROB

@tgross tgross requested a review from philrenaud December 14, 2023 16:26
@tgross
Copy link
Member

tgross commented Dec 14, 2023

Tagging in @philrenaud for any thoughts

Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks, @Sanskar531 !

@Sanskar531
Copy link
Contributor Author

This looks good! Thanks, @Sanskar531 !

All good! Do you need me to do anything else?

@philrenaud
Copy link
Contributor

Nope! Checks all passed on this, so merging it to main now.

Thanks again for your work on this, and look for it in an upcoming release!

@philrenaud philrenaud merged commit 7a87049 into hashicorp:main Dec 18, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

5 participants