[ui] bugfix: when hitting the "start" button on a job page, if it has no submission data, fallback to raw json definition #18621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
tgross
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
LGTM! 👍
It occurs to me this whole feature is a bit racy in that another user can submit a new job definition between the time we get the job spec and re-run it. As a future improvement we might want to consider using EnforceIndex so that someone pressing the Start button can't accidentally roll-back the job. But that shouldn't be part of this bug fix!
philrenaud
force-pushed
the
18547-job-cannot-be-restarted-from-ui-in-162
branch
from
4da2a7f to
e7fa4b3
Compare
dhung-hashicorp
added
hcc/cst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nomad 1.6, we introduced HCL-in-the-UI using a new /submissions endpoint among other things.
Shortly after the release, we realized we missed a spot: stop/starting via the UI would not maintain the submission data. My initial fix for this solved the issue of maintaining HCL, but caused a new bug: jobs that lacked submission data (perhaps they were submitted via curl with just the json spec, and without HCL) would 404 on /submission and fail to progress through to /parse and submit.
This PR provides a fallback to the initial method in cases where the /submission request fails.
Resolves #18547
Resolves #18536