Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver.rkt: support network configuration #1862

Merged
merged 5 commits into from
Oct 27, 2016
Merged

driver.rkt: support network configuration #1862

merged 5 commits into from
Oct 27, 2016

Conversation

schmichael
Copy link
Member

@schmichael schmichael commented Oct 26, 2016

Thanks to @nak3 for the original PR! #1616

I rebased on master, fixed the test, and changed the docs to include an example that should Just Work for anyone with rkt installed.

@nak3 I'd love if you could verify my changes. I'm new to rkt networking and having to specify port names that are defined either in the image or on the system was a little confusing to me.

@schmichael schmichael changed the title driver.rkt: update driver fingerprint driver.rkt: support network configuration Oct 26, 2016
@schmichael schmichael changed the title driver.rkt: support network configuration driver.rkt: support network configuration [waiting] Oct 26, 2016
@schmichael
Copy link
Member Author

Not planning on merging this in for 0.5 unless someone shows up who really needs it.

@blalor
Copy link
Contributor

blalor commented Oct 27, 2016

That's definitely a feature I'm missing in the current rkt driver. I won't need it for a couple of weeks, but I'll be looking for it soon after that.

@schmichael
Copy link
Member Author

@blalor @salehe Thanks for responding! We're about to cut a release candidate for the 0.5 release. If I merge this in do you think you'd be able to test it in the next few days?

I've verified it works, but I don't know if the configuration is the best way to expose rkt port mapping. It seems to require the image or system rkt config have the port map defined before you can use it in the port_map task config in nomad.

If it looks like it fits your needs I'll happily merge it!

@schmichael schmichael merged commit 6821210 into master Oct 27, 2016
@schmichael
Copy link
Member Author

@blalor @salehe Sorry for the noise: we merged as-is. Please let me know if this works for you.

@schmichael schmichael deleted the f-rkt-portmap branch October 27, 2016 18:06
@schmichael schmichael changed the title driver.rkt: support network configuration [waiting] driver.rkt: support network configuration Nov 9, 2016
schmichael added a commit that referenced this pull request Nov 9, 2016
schmichael added a commit that referenced this pull request Nov 9, 2016
Remove warning since #1862 added ports support
@blalor
Copy link
Contributor

blalor commented Dec 3, 2016

This has been working great for me. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants