-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
driver.rkt: support network configuration #1862
Conversation
Not planning on merging this in for 0.5 unless someone shows up who really needs it. |
That's definitely a feature I'm missing in the current rkt driver. I won't need it for a couple of weeks, but I'll be looking for it soon after that. |
@blalor @salehe Thanks for responding! We're about to cut a release candidate for the 0.5 release. If I merge this in do you think you'd be able to test it in the next few days? I've verified it works, but I don't know if the configuration is the best way to expose rkt port mapping. It seems to require the image or system rkt config have the port map defined before you can use it in the If it looks like it fits your needs I'll happily merge it! |
Remove warning since #1862 added ports support
This has been working great for me. Thank you! |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Thanks to @nak3 for the original PR! #1616
I rebased on master, fixed the test, and changed the docs to include an example that should Just Work for anyone with rkt installed.
@nak3 I'd love if you could verify my changes. I'm new to rkt networking and having to specify port names that are defined either in the image or on the system was a little confusing to me.