fix: use interpolated address when performing health checks #18584
Conversation
There was a problem hiding this comment.
Hi @MattJustMatt and thanks for the PR. The approach seems right to me, but. the change in function signature has broken some tests, which will need to be fixed up. It would also be nice to add some additional tests to cover the new behaviour and ensure interpolated service checks work as we now expected. Finally, a changelog entry for the addition can be included by running the make cl command.
Thanks again!
|
@jrasell Thanks for the review! I've fixed the broken tests and added the changelog entry. I don't have a good enough understanding of the test infra to easily add a regression test for this, but if it's needed for this PR please let me know and I can dive in deeper. |
There was a problem hiding this comment.
LGTM! If you don't mind just tweaking the CL comment so it clarifies this is about nomad service checks @MattJustMatt
|
100% cool with me! |
Co-authored-by: Seth Hoenig <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@MattJustMatt is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
shoenig
added
backport/1.4.x
Fixes #18574