Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role update functionality to acl token update #18532

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Kartik1397
Copy link
Contributor

This pull request adds the ability to update roles in the acl token update command.

Fixes: #18354

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @Kartik1397, thank you for the PR! I left a suggestion about how to handle the removal of roles from a token.

Would you also be able to update the documentation page to include these new flags?
https://github.com/hashicorp/nomad/blob/main/website/content/docs/commands/acl/token/update.mdx

And also run the command make cl to generate a CHANGELOG entry.

Thanks again for the contribution!

command/acl_token_update.go Show resolved Hide resolved
command/acl_token_update.go Outdated Show resolved Hide resolved
@tgross tgross added the stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows label May 17, 2024
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this PR on main, pushed a changelog entry, resolved the open comments, and added documentation updates. Will merge once this is green and that'll ship in Nomad 1.8.3.

@tgross tgross added theme/cli theme/auth type/enhancement backport/1.8.x backport to 1.8.x release line and removed stage/needs-rebase This PR needs to be rebased on main before it can be backported to pick up new BPA workflows labels Aug 8, 2024
@tgross tgross merged commit 3a3e63e into hashicorp:main Aug 8, 2024
32 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

[cli] Allow "role" updates to tokens
4 participants