-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role update functionality to acl token update #18532
Conversation
ce2bba2
to
0203ec6
Compare
0203ec6
to
2fdcf74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good @Kartik1397, thank you for the PR! I left a suggestion about how to handle the removal of roles from a token.
Would you also be able to update the documentation page to include these new flags?
https://github.com/hashicorp/nomad/blob/main/website/content/docs/commands/acl/token/update.mdx
And also run the command make cl
to generate a CHANGELOG entry.
Thanks again for the contribution!
2fdcf74
to
c16fb91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased this PR on main
, pushed a changelog entry, resolved the open comments, and added documentation updates. Will merge once this is green and that'll ship in Nomad 1.8.3.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This pull request adds the ability to update roles in the
acl token update
command.Fixes: #18354