Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Add prune flag for nomad server force-leave command #18463

Merged
merged 7 commits into from
Sep 15, 2023
Merged

feature: Add prune flag for nomad server force-leave command #18463

merged 7 commits into from
Sep 15, 2023

Conversation

nvanthao
Copy link
Contributor

This feature will help operator to remove a failed/left node from Serf layer immediately without waiting for 24 hours for the node to be reaped

  • Update CLI with prune flag
  • Update API /v1/agent/force-leave with prune query string parameter
  • Update CLI and API doc
  • Add unit test

@nvanthao nvanthao self-assigned this Sep 12, 2023
@nvanthao nvanthao linked an issue Sep 12, 2023 that may be closed by this pull request
Adding prune capabilties to nomad force-leave option #8840
Closed
@tgross tgross self-requested a review September 12, 2023 14:34
tgross
tgross requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nvanthao! Thanks for the PR, this is a good start. I've left some comments that'll need to be addressed before this can be merged.

api/agent.go Outdated Show resolved Hide resolved
command/server_force_leave.go Outdated Show resolved Hide resolved
command/agent/agent_endpoint.go Outdated Show resolved Hide resolved
api/agent_test.go Outdated Show resolved Hide resolved
@nvanthao nvanthao requested a review from tgross September 13, 2023 13:44
tgross
tgross requested changes Sep 13, 2023
View reviewed changes
command/server_force_leave.go Outdated Show resolved Hide resolved
website/content/docs/commands/server/force-leave.mdx Outdated Show resolved Hide resolved
website/content/docs/commands/server/force-leave.mdx Outdated Show resolved Hide resolved
api/agent_test.go Outdated Show resolved Hide resolved
api/agent_test.go Outdated Show resolved Hide resolved
@tgross
Copy link
Member

tgross commented Sep 13, 2023

@nvanthao you'll want to rebase this on main and that'll get the remaining failing test working

@nvanthao
Copy link
Contributor Author

Many thanks @tgross! I have updated the PR with your latest feedback!

@nvanthao nvanthao requested a review from tgross September 14, 2023 00:46
tgross
tgross requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting really close @nvanthao, I think this is the last round of issues.

command/agent/agent_endpoint.go Outdated Show resolved Hide resolved
website/content/api-docs/agent.mdx Outdated Show resolved Hide resolved
@nvanthao
feature: Add prune flag for nomad server force-leave command
2beea58 
This feature will help operator to remove a failed/left node from Serf layer immediately
without waiting for 24 hours for the node to be reaped

* Update CLI with prune flag
* Update API /v1/agent/force-leave with prune query string parameter
* Update CLI and API doc
* Add unit test
@nvanthao
add changelog
8cc8f0e
@nvanthao nvanthao requested a review from tgross September 14, 2023 21:41
@nvanthao
Copy link
Contributor Author

many thanks @tgross for being patient with me! next PRs will be better!

tgross
tgross approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for sticking with it @nvanthao!

@tgross tgross merged commit 1339599 into main Sep 15, 2023
@tgross tgross deleted the f-force-leave-prune branch September 15, 2023 12:45
@tgross tgross added the backport/1.6.x backport to 1.6.x release line label Sep 15, 2023
@tgross tgross added this to the 1.6.x milestone Sep 15, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Sep 15, 2023
Merged
@tgross tgross mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

Assignees

@nvanthao nvanthao

Labels
backport/1.6.x backport to 1.6.x release line theme/api HTTP API and SDK issues theme/cli type/enhancement
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
1.6.x
Development

Successfully merging this pull request may close these issues.

Adding prune capabilties to nomad force-leave option
2 participants
@nvanthao @tgross