Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpuset: make sure the cgroups driver combos cgroupfs+cgroupsv2 and docker+cgroups1 work #18461

Closed
shoenig opened this issue Sep 12, 2023 · 2 comments
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cgroups cgroups issues type/enhancement
Milestone

Comments

@shoenig
Copy link
Member

shoenig commented Sep 12, 2023

#18371 is a major refactoring of how Nomad manages cgroups. There are many combinations of platforms and drivers and configurations of docker, etc. The mainstream Linux distros should already work as of that PR, but this issue is a reminder to go back and ensure the less common combinations also still work. In particular systems configured with

  1. cgroupsv2 + docker using cgroupsfs cgroups driver
  2. cgroupsv1 + docker using docker cgroups driver

exist in the wild but not out of the box.

@shoenig shoenig added type/enhancement stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cgroups cgroups issues labels Sep 12, 2023
@shoenig shoenig added this to the 1.7.0 milestone Sep 12, 2023
@shoenig shoenig self-assigned this Sep 12, 2023
@shoenig shoenig modified the milestones: 1.7.0, 1.7.x Dec 1, 2023
@shoenig
Copy link
Member Author

shoenig commented Dec 1, 2023

Tested by configuring /etc/docker/daemon.json with

{
  "exec-opts": ["native.cgroupdriver=systemd"]
}

and

{
  "exec-opts": ["native.cgroupdriver=cgroupfs"]
}

on both Ubuntu 22.04 (cgroups v2) and Ubuntu 20.04 (cgroups v1); in all 4 cases the standard redis example job was able to launch and run fine.

@shoenig shoenig closed this as completed Dec 1, 2023
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cgroups cgroups issues type/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant