Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal creates an auto-constraints #1839

Merged
merged 4 commits into from
Oct 25, 2016
Merged

Signal creates an auto-constraints #1839

merged 4 commits into from
Oct 25, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Oct 20, 2016

This PR adds a constraint such that jobs requesting signals only go to machines/drivers that can handle them.

…the signal. Also fixes a bug with plan and implicit constraints by adding them to the job being planned
@schmichael
Copy link
Member

LGTM

Should we strings.ToLower() signals at some point to ensure they're compared in a normalized fashion? (eg SIGUSR1 == sigusr1)

@diptanu
Copy link
Contributor

diptanu commented Oct 25, 2016

My opinion is that this constraint is not needed - A user can use the kernel constraint to make a job run on an OS which has the signals that the job needs. This is just another way of targeting a platform which supports a certain POSIX API.

And if a user mistypes a SIGNAL name, I think it's fine for it to be a runtime error which is no different than passing a wrong argument to the program.

@dadgar dadgar merged commit b0749c7 into master Oct 25, 2016
@dadgar dadgar deleted the f-signal-constraints branch October 25, 2016 18:09
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants