A couple fixes to make Docker For Mac work #1806
Conversation
|
|
||
| p, err = filepath.EvalSymlinks(p) | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
I believe we should prefix this error with something so we can trace it better (see other errors for examples)
* In -dev mode, `ioutil.TempDir` is used for the alloc and state directories. * `TempDir` uses `$TMPDIR`, which os OS X contains a per user directory which is under `/var/folder`. * `/var` is actually a symlink to `/private/var` * Docker For Mac validates the directories that are passed to bind and on OS X. That whitelist contains `/private`, but not `/var`. It does not expand the path, and so any paths in `$TMPDIR` fail the whitelist check. And thusly, by expanding the alloc/state directories the value passed for binding does contain `/private` and Docker For Mac is happy.
The syslog logging system depends on the ability for a unix socket to be accessed by the docker daemon in the $TMPDIR of the host. This doesn't work on Docker For Mac because the docker daemon is running inside a VM, and while /tmp is accessible, the filesystem used to share them doesn't support unix socket files, and thus it doesn't work.
|
This PR currently triggers a panic: https://gist.github.com/evanphx/e3883d68062ff4c67ee0b6e5633df077 |
evanphx
force-pushed
the
f-docker4mac-fixes
branch
from
d8e2a33 to
5f2b967
Compare
|
Experiencing another crash: https://gist.github.com/evanphx/48a594053af828e9179169bc724a36c3 |
|
any love for this PR before 0.5.0 ? :) |
|
Hi @jippi Thank you for your comment. We are currently investigating why this PR is causing an upstream panic and crash. Until we can resolve that, we won't be able to get this into a release. Thanks! 😄 |
|
yay @dadgar ! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This should fix #1080 as well as #1091