Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Copy change to include the nomad/jobs all-access variable prefix #17933

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[ui] Copy change to include the nomad/jobs all-access variable prefix #17933

merged 1 commit into from
Jul 20, 2023

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Jul 13, 2023 •
edited
Loading

Resolves #17931

@philrenaud philrenaud requested a review from juliezzhou July 13, 2023 14:05
@philrenaud philrenaud self-assigned this Jul 13, 2023
@philrenaud philrenaud linked an issue Jul 13, 2023 that may be closed by this pull request
[ui] Add helper text to allow variables file to access multiple jobs #17931
Closed
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Ember Test Audit comparison

main 6e4603e change
passes 1498 1498 0
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud force-pushed the 17931-ui-add-helper-text-to-allow-variables-file-to-access-multiple-jobs branch from 0b313bd to 6e4603e Compare July 20, 2023 16:46
juliezzhou
juliezzhou approved these changes Jul 20, 2023
View reviewed changes
Copy link

@juliezzhou juliezzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philrenaud philrenaud added the backport/1.6.x backport to 1.6.x release line label Jul 20, 2023
@philrenaud philrenaud merged commit 6bed12f into main Jul 20, 2023
@philrenaud philrenaud deleted the 17931-ui-add-helper-text-to-allow-variables-file-to-access-multiple-jobs branch July 20, 2023 18:16
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliezzhou juliezzhou juliezzhou approved these changes

Assignees

@philrenaud philrenaud

Labels
backport/1.6.x backport to 1.6.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui] Add helper text to allow variables file to access multiple jobs
2 participants
@philrenaud @juliezzhou