Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Text wrap long lines of code and logs #17754

Merged
merged 7 commits into from
Jun 30, 2023
Merged

[ui] Text wrap long lines of code and logs #17754

merged 7 commits into from
Jun 30, 2023

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Jun 27, 2023 •
edited
Loading

Lets a user wrap text in their logs and job definitions.

  • Adds a "Wrap" button to job definitions and logs in the UI
  • Preference saved to localStorage, so persists across refresh
  • Adds a keyboard shortcut (ww) to toggle

image
image

TODO: tests

Resolves #17749

@philrenaud philrenaud self-assigned this Jun 27, 2023
@philrenaud philrenaud linked an issue Jun 27, 2023 that may be closed by this pull request
UI: Text wrap long lines of code and logs and text #17749
Closed
@github-actions
Copy link

github-actions bot commented Jun 27, 2023 •
edited
Loading

Ember Test Audit comparison

main 320fea9 change
passes 1494 1496 +2
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

pkazmierczak
pkazmierczak approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philrenaud philrenaud merged commit 6124c1a into main Jun 30, 2023
@philrenaud philrenaud deleted the f-ui/17749-ui-text-wrap-long-lines-of-code-and-logs-and-text branch June 30, 2023 21:07
@philrenaud philrenaud mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkazmierczak pkazmierczak pkazmierczak approved these changes

@mikenomitch mikenomitch Awaiting requested review from mikenomitch

@juliezzhou juliezzhou Awaiting requested review from juliezzhou

Assignees

@philrenaud philrenaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Text wrap long lines of code and logs and text
2 participants
@philrenaud @pkazmierczak