ui: remove redundant columns from child job table #17645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace, job type, and priority are already available from the parent job header, so displaying them in the table caused it to be too crowded.
lgfa29
force-pushed
the
f-ui-simplify-child-job-row
branch
from
2fe9ed2 to
fb0e6bd
Compare
Ember Test Audit comparison
|
philrenaud
reviewed
Jun 22, 2023
| <td data-test-job-priority> | ||
| {{this.job.priority}} | ||
| </td> | ||
| {{#if (not (eq @context "child"))}} |
There was a problem hiding this comment.
I was about to suggest {{#unless (eq @context "child")}} but it turns out that's not recommended: https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/simple-unless.md
There was a problem hiding this comment.
Yeah, for some reason I find unless really confusing so I tend to avoid it 😅
philrenaud
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace, job type, and priority are already available from the parent job header, so displaying them in the table caused it to be too crowded.
(Extracted from #17301 as a user-facing change)