[ui] Fixed: Evaluations sidebar/response not scrollable #16960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
commented
Apr 21, 2023
| display: grid; | ||
| min-height: 200px; | ||
| grid-template-rows: auto 1fr; | ||
| overflow: hidden; |
There was a problem hiding this comment.
The parent evaluation response container has overflow: hidden deliberately: it contains both the header and the json viewer, the latter of which has auto overflow.
philrenaud
commented
Apr 21, 2023
| } | ||
| & > div, | ||
| h1.title { | ||
| margin: 0; |
There was a problem hiding this comment.
Let the flex/grid parent handle gap/margin where possible
philrenaud
force-pushed
the
16945-ui-evaluations-sidebar-evaluation-response-not-scrollable
branch
from
d06e298 to
5f1f452
Compare
Ember Asset Size actionAs of bb9927d Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
ChaiWithJai
approved these changes
Apr 24, 2023
philrenaud
deleted the
16945-ui-evaluations-sidebar-evaluation-response-not-scrollable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR establishes CSS flexbox regions in the Evaluations sidebar so both it, and the evaluation response, can be scrolled.