cli: fix panic on job plan when -diff=false #16944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #14492 introduced a new check to return 0 when the `nomad job plan` command returns a diff of type `None`. But the `-diff` CLI flag was also being used to control whether the plan request should return the diff of not instead of just controlling if the diff was printed. This means that when `-diff=false` is set the response does not include any diff information, and so the new check panics. This commit fixes the problem by always requesting a diff and using the `-diff` only for controlling output, as it's currently documented.
lgfa29
added
backport/1.4.x
|
#14492 mentions that the change will be released in the next 1.4 patch release, but the change wasn't actually backported so it only came out in 1.5.0. |
Closed
schmichael
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14492 introduced a new check to return 0 when the
nomad job plancommand returns a diff of typeNone.But the
-diffCLI flag was also being used to control whether the plan request should return the diff of not instead of just controlling if the diff was printed.This means that when
-diff=falseis set the response does not include any diff information, and so the new check panics.This commit fixes the problem by always requesting a diff and using the
-diffonly for controlling output, as it's currently documented.Closes #16939