Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancements for the upcoming JWT authentication method #16521

Closed
pkazmierczak opened this issue Mar 16, 2023 · 3 comments
Closed

UI enhancements for the upcoming JWT authentication method #16521

pkazmierczak opened this issue Mar 16, 2023 · 3 comments

Comments

@pkazmierczak
Copy link
Contributor

Currently, Nomad UI supports logging in via an SSO if an ACL Auth Method is detected in the state store. Unauthenticated users are then presented with the following message:

Screenshot 2023-03-16 at 16 27 59

And later when then click on either the auth method name or the Nomad ACL Token link, they are redirected to the following:

Screenshot 2023-03-16 at 16 29 06

We will soon introduce a new auth method type, JWT, that does not require a redirect to a 3rd party provider, and in fact is just a string of characters much like the Nomad ACL Token. I see two possible ways we could address this in the UI:

  • Detect if the type of an ACL Auth Method is JWT or OIDC, and present a different dialog to the user depending on that, or:
  • Detect the shape of the token that is being pasted into the "Secret ID" text field. If it's JWT-shaped, call the /v1/acl/login endpoint, if it's not, treat it as a Nomad ACL Token.

The new /acl/login endpoint will expect an auth method name (just like the OIDC endpoint), and a token.

@pkazmierczak
Copy link
Contributor Author

FYI all the backend code has been reviewed and merged into a feature branch; could be useful for testing.

@philrenaud philrenaud moved this from Backlog to Todo in Nomad UI Mar 22, 2023
@philrenaud philrenaud moved this from Todo to In Progress in Nomad UI Mar 23, 2023
@philrenaud philrenaud moved this from In Progress to In Review in Nomad UI Mar 29, 2023
@philrenaud
Copy link
Contributor

Resolved by #16625 and #16665

@github-project-automation github-project-automation bot moved this from In Review to Done in Nomad UI Mar 29, 2023
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants