cli: Add -json and -t flags to namespace status command
#16442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanadelacuesta
changed the title
-json and -t flags to namespace status command
Juanadelacuesta
changed the title
-json and -t flags to namespace status command-json and -t flags to namespace status command
jrasell
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Looking good, thanks!
The PR will need a changelog entry added. Also if we could move the additional tests added to use must, that would be great. An optional change would be to move all the new and current tests in the file to use must, but this isn't required on this PR. :D
Co-authored-by: James Rasell <[email protected]>
jrasell
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
LGTM, thanks @Juanadelacuesta! Lets add the backport 1.5.x label before merging this in.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.