Outage recovery link fix #16365
Merged
Outage recovery link fix #16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
outage-recovery-link-fix
branch
from
60db915 to
097a0bc
Compare
Ember Asset Size actionAs of 097a0bc Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
ChaiWithJai
reviewed
Mar 7, 2023
| @@ -43,7 +43,7 @@ | |||
| <h1 data-test-error-title class="title is-spaced">No Cluster Leader</h1> | |||
| <p data-test-error-message class="subtitle"> | |||
| The cluster has no leader. | |||
| <a href="https://www.nomadproject.io/guides/outage.html"> | |||
| <a href="https://developer.hashicorp.com/nomad/tutorials/manage-clusters/outage-recovery"> | |||
There was a problem hiding this comment.
There are 7 references to the previous domain. Should we examine those outbound links and convert this to a constant that we reference throughout the codebase?
There was a problem hiding this comment.
That's just in the UI; there are many more in the API/CLI/etc. Most of those links are still live and working, but this one isn't.
ChaiWithJai
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the link to recovering from outage (shown in the UI if a cluster leader is not elected) was 404ing; this returns the updated link.