Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbold header Device Group Attributes and remove unused var in func nodeCSIVolumeNames #16138

Merged

Conversation

dttung2905
Copy link
Contributor

Hi team,

This PR aims to fix #12816. I find unused variable in func nodeCSIVolumeNames so I removed it as well

Signed-off-by: dttung2905 <[email protected]>
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's fix up the changelog and this can get merged (done by Charlie). Thanks for the PR @dttung2905!

.changelog/16138.txt Outdated Show resolved Hide resolved
@tgross tgross added this to the 1.5.0 milestone Feb 13, 2023
@tgross tgross self-assigned this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

cli: formatting of device group attributes header
3 participants