users: create cache for user lookups #16100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
user-exp-cache-2
branch
3 times, most recently
from
75bdb41 to
bac08fb
Compare
This PR introduces a global cache for OS user lookups. This should relieve pressure on the OS domain/directory lookups, which would be queried more now that Task API exists. Hits are cached for 1 hour, and misses are cached for 1 minute. These values are fairly arbitrary - we can tweak them if there is any reason to. Closes #16010
shoenig
force-pushed
the
user-exp-cache-2
branch
from
bac08fb to
d7f690e
Compare
lgfa29
approved these changes
Feb 9, 2023
Comment on lines
+24
to
+25
| userCache map[string]*entry[*user.User] | ||
| userFailureCache map[string]*entry[error] |
There was a problem hiding this comment.
Any concerns about unlimited memory growth? I don't expect these to grow too much, and creating another GC routine is a bit much 😅 but maybe we can delete entries on read once they expire?
There was a problem hiding this comment.
Oh yeah that's a nice idea. In practice this should always be zero, but yeah people certainly do stuff to their clusters.
Comment on lines
+20
to
+21
| u, err := c.GetUser("nobody") | ||
| must.NoError(t, err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a global cache for OS user lookups. This should
relieve pressure on the OS domain/directory lookups, which would be
queried more now that Task API exists.
Hits are cached for 1 hour, and misses are cached for 1 minute. These
values are fairly arbitrary - we can tweak them if there is any reason to.
Closes #16010