deps: upgrade to hashicorp/golang-lru/v2 #16085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoenig
force-pushed
the
update-golang-lru-v2
branch
2 times, most recently
from
9e97c01 to
2436afa
Compare
shoenig
changed the title
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
2436afa to
633cef7
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
633cef7 to
b85d9b3
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
b85d9b3 to
d771f9d
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
d771f9d to
13dbfb7
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
13dbfb7 to
758862e
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
2 times, most recently
from
d7a844e to
e86a86e
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
e86a86e to
fd00d4e
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
fd00d4e to
a3ae76d
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
a3ae76d to
b10620d
Compare
shoenig
force-pushed
the
update-golang-lru-v2
branch
from
b10620d to
6d2ac54
Compare
tgross
approved these changes
Feb 8, 2023
| ValidACLAuthMethod = regexp.MustCompile("^[a-zA-Z0-9-]{1,128}$") | ||
| ) | ||
|
|
||
| type ACLCacheEntry[T any] lang.Pair[T, time.Time] |
There was a problem hiding this comment.
Just for my education, what does lang.Pair get us over something like this?
type ACLCacheEntry[T any] struct {
val T
t time.Time
}There was a problem hiding this comment.
It's just a way to signal the (combined) type is irrelevant - it's an implementation detail of the cache, so there isn't much need to declare a whole type around it
There was a problem hiding this comment.
Gotcha, cool. There's probably a bunch of other places this would be handy too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to hashicorp/golang-lru/v2, and refactor the ACL cache to leverage all the generics. Previously each cache entry contained 3 pointers, only one of which would be in use - so we should get some space savings out of that (not that the cache sizes are large).