Add support for initial check status #1599
Conversation
| case api.HealthWarning: | ||
| case api.HealthCritical: | ||
| default: | ||
| return fmt.Errorf(`invalid initial check state (%s), must be one of "%s", "%s", "%s", or "%s"`, sc.InitialStatus, api.HealthUnknown, api.HealthPassing, api.HealthWarning, api.HealthCritical) |
There was a problem hiding this comment.
invalid initial check state (%s), must be one of %q, %q, %q, %q or empty
|
@hoffoo Thanks! Left one small comment. |
| } | ||
|
|
||
| _, err = ParseFile(path) | ||
|
|
There was a problem hiding this comment.
We should also check that parsing the file resulted in the check that we are expecting by using reflect.DeepEquals
There was a problem hiding this comment.
okay! it turns out it was actually broken without the mapstructure tag :x
|
@hoffoo Thanks! I am merging this one. |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
accidentally closed the pr, here is a proper commit for initial check status
old thread: #1573