Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes generate Secret ID and used retrieving allocations/registering #1597

Merged
merged 4 commits into from
Aug 19, 2016
Merged

Nodes generate Secret ID and used retrieving allocations/registering #1597

merged 4 commits into from
Aug 19, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Aug 16, 2016 •
edited
Loading

Also fixes client tests
@diptanu for review

@dadgar dadgar force-pushed the f-node-secret-id branch 2 times, most recently from 3d95140 to e7b2def Compare August 16, 2016 18:04
@diptanu diptanu changed the base branch from f-nomad-0.5 to master August 17, 2016 23:40
@diptanu
Copy link
Contributor

diptanu commented Aug 17, 2016

Handle the in-place upgrade path.

@diptanu
Copy link
Contributor

diptanu commented Aug 19, 2016

I think the right behavior would be - When a node registers and doesn’t provide a secret id, the server returns one if the node was previously registered and didn't have a secret id. The client should never generate a secret id, if it has a secret id and if that doesn’t match with what server has, the server can reject the registration. The client should just store whatever the server is sending in the state file and if an operator has tempered it, next time the node won't get registered until the state file is removed.

@dadgar
Copy link
Contributor Author

dadgar commented Aug 19, 2016

Talked offline with Diptanu

@dadgar dadgar merged commit 0eb8947 into master Aug 19, 2016
@sethvargo sethvargo deleted the f-node-secret-id branch November 1, 2016 01:55
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dadgar @diptanu