WI: allow workloads to use RPCs associated with HTTP API #15870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also wires up pre-forwarding authentication for RPCs that don't support the API, so that we can reuse the shared `ResolveACLorClient` method here.
tgross
force-pushed
the
auth-with-wi-claims
branch
from
e402842 to
18f5cec
Compare
schmichael
reviewed
Jan 25, 2023
|
In addition to running the unit tests I've tested this out by spinning up a 3 server cluster along with a client, and verified that the job deployment workflow is running, that client APIs (ex. |
Closed
schmichael
approved these changes
Jan 25, 2023
| @@ -890,7 +898,7 @@ func (n *Node) GetNode(args *structs.NodeSpecificRequest, | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if !aclObj.AllowNodeRead() { | |||
| if aclObj != nil && !aclObj.AllowNodeRead() { | |||
There was a problem hiding this comment.
Huh, how did this sneak by? I would think it would panic on nomad node status ... for everyone with ACLs disabled?
There was a problem hiding this comment.
Yeah that burned me here... the old ResolveToken code returns nil, nil in that case, so we just skip over the AllowNodeRead check. Fortunately we have good unit test coverage of non-ACLs vs with-ACLs and that caught it.
tgross
added a commit
that referenced
this pull request
Jan 25, 2023
This changeset configures the RPC rate metrics that were added in #15515 to all the RPCs that support authenticated HTTP API requests. These endpoints already configured with pre-forwarding authentication in #15870, and a handful of others were done already as part of the proof-of-concept work. So this changeset is entirely copy-and-pasting one method call into a whole mess of handlers. Upcoming PRs will wire up pre-forwarding auth and rate metrics for the remaining set of RPCs that have no API consumers or aren't authenticated, in smaller chunks that can be more thoughtfully reviewed.
tgross
added a commit
that referenced
this pull request
Jan 25, 2023
This changeset configures the RPC rate metrics that were added in #15515 to all the RPCs that support authenticated HTTP API requests. These endpoints already configured with pre-forwarding authentication in #15870, and a handful of others were done already as part of the proof-of-concept work. So this changeset is entirely copy-and-pasting one method call into a whole mess of handlers. Upcoming PRs will wire up pre-forwarding auth and rate metrics for the remaining set of RPCs that have no API consumers or aren't authenticated, in smaller chunks that can be more thoughtfully reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset allows Workload Identities to authenticate to all the RPCs that
support HTTP API endpoints, for use with PR #15864.
support a HTTP API endpoint.
endpoints that are currently used to support both tokens and client secrets.
Intentionally excluded from this changeset:
policies. Ideally we'll figure out an efficient way to resolve those into real
policies and then we can get rid of that custom handling.
support HTTP endpoints) have not been updated with the new pre-forwarding auth
We'll be doing this under a separate PR to support RPC rate metrics.