connect: ingress gateway validation for http hosts and wildcards #15749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes code match the documentation, and reality 😋
Applies to all non-"tcp" protocols:
http
,http2
, andgrpc
, which support "hosts" and tests now cover all of them as well. I could maybe be convinced to remove the extra test coverage if it seems superfluous, but it's intended to guard against potential future regressions.per https://developer.hashicorp.com/nomad/docs/job-specification/gateway#service-parameters,
e.g. this will now work:
and this will no longer work (by "work" I mean pass to consul, which errors less-specifically):
error before:
error after:
Closes #10955
Note: to use these non-"tcp" protocols, users will still need to manually write a service-defaults Consul config entry as described in #8647 (comment)