vault: configure user agent on Nomad vault clients #15745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR attempts to set the User-Agent header on each Vault API client created by Nomad. Still need to figure a way to set User-Agent on the Vault client created internally by consul-template.
shoenig
force-pushed
the
b-set-useragent-more
branch
from
efcd250 to
26fd3ee
Compare
lgfa29
reviewed
Jan 10, 2023
client/vaultclient/vaultclient.go
Outdated
Comment on lines
356
to
355
| // Set the token in the API client to the one that needs | ||
| // SetHeaders the token in the API client to the one that needs |
There was a problem hiding this comment.
Was this a find-and-replace gone wild? There are some others like this in nomad/vault.go as well 😅
There was a problem hiding this comment.
Ah crap, I dunno how I didn't see this
lgfa29
approved these changes
Jan 10, 2023
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to set the User-Agent header on each Vault API client
created by Nomad. Still need to figure a way to set User-Agent on the
Vault client created internally by consul-template.
Partial of #15629