fix: Make agent syslog log level inherit from Nomad agent log

[dttung2905]

Fix issue : #15087

Hi Nomad Core Dev team,

Below is my attempt to fix the issue mentioned above. Imo, we can either make an extra argument for syslog log level or make it inherit from Nomad Agent existing one. This PR is using the latter approach because there is not need to use the former for a rarely used feature.

Would appreciate getting your feedback on this PR, especially on a few issues:

• On the mapping between gsyslog and Nomad Agent log, I'm not entirely sure about how OFF and TRACE in Nomad log_level maps to gsyslog log level
• I attempted to write one similar to TestCommand_Args() but the log is not captured by either ui.ErrorWriter or ui.OutputWriter. Please let me know if a unit test is needed or there are better ways to structure the unit test

[tgross]

This looks great @dttung2905! I agree that it makes the best sense to have the syslog logger inherit the log level from the agent. I've left a suggestion for how to treat the "OFF" level, but I think what you've done for "TRACE" is fine.

Thanks for the PR!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nomad-storybook-and-ui	🔄 Building (Inspect)		Jan 4, 2023 at 2:09AM (UTC)

[tgross]

Looking good! I found one minor issue around case handling that became obvious once we checked for OFF. Once that's fixed I think this is ready for merge.

[tgross]

LGTM! Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.