-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Adding canary_tags the web UI #15458
[ui] Adding canary_tags the web UI #15458
Conversation
ea66523
to
66f3131
Compare
Ember Asset Size actionAs of b2d7c3c Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
&:before { | ||
content: "Canary"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fun CSS trick to add copy to an element without adding it in the template itself.
{{#each @service.canary_tags as |tag|}} | ||
<span class="tag canary is-service">{{tag}}</span> | ||
{{/each}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than make these their own conditional table column, decided to append them to the end of the rest of the tags
on a service, should they exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but LGTM.
I wonder if it would be possible to apply the correct set of tags instead of always displaying them all depending on the allocation deployment status:
$ nomad operator api /v1/allocations | jq '.[].DeploymentStatus'
{
"Canary": false,
"Healthy": true,
"ModifyIndex": 24,
"Timestamp": "2022-12-05T15:32:23.764038-03:00"
}
{
"Canary": true,
"Healthy": true,
"ModifyIndex": 35,
"Timestamp": "2022-12-05T15:33:13.774562-03:00"
}
So the canary_tags
would only show for canary allocs, and the tags
would show for non-canary.
@lgfa29 I was thinking about this, but figured it might be worthwhile to say something like "... and if this alloc is ever in a |
I think the use of |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Appending, with a custom style, to anyplace we show service tags:
Resolves #13018