[ui] Token management interface on policy pages #15435

philrenaud · 2022-11-30T20:08:53Z

Adds the ability to view, delete, and create tokens associated with a given policy in the new Policies UI.

Ability to do any of this is available only to manager tokens only.

github-actions · 2022-11-30T20:16:05Z

Ember Asset Size action

As of 0200e2d

Files that got Bigger 🚨:

File	raw	gzip
nomad-ui.js	+8.96 kB	+1.55 kB
nomad-ui.css	+746 B	+136 B

Files that stayed the same size 🤷‍:

File	raw	gzip
vendor.js	0 B	0 B
vendor.css	0 B	0 B

github-actions · 2022-11-30T20:55:03Z

Ember Test Audit comparison

	main	`0200e2d`	change
passes	1442	1449	+7
failures	1	0	-1
flaky	0	0	0
duration	000ms	11m 59s 193ms	+11m 59s 193ms

vercel · 2022-12-06T18:42:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nomad-storybook-and-ui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Dec 6, 2022 at 6:48PM (UTC)

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nomad	⬜️ Ignored (Inspect)			Dec 6, 2022 at 6:48PM (UTC)

philrenaud · 2022-12-08T21:53:28Z

ui/app/styles/components/policies.scss

+@media #{$mq-hidden-gutter} {
+  .token-operations {
+    grid-auto-flow: row;
+    grid-template-columns: 1fr;
+  }
+}


De-columnizes things if you're on a narrow screen

mikenomitch · 2022-12-08T22:54:50Z

Feeling really good.

Small ignorable request: When you create an example token, do you think we could auto-copy to the clipboard? Seems marginally nicer than having the user copy from the alert.

Also, I think the policy name has to be wrapped in quotes in case they have a space. This command will fail for instance:
nomad acl token create -name="<TOKEN_NAME>" -policy=back up -type=client -ttl=<8h>

Should Policy Deleted and Token Deleted alerts be auto-removed? I see why the Example Token created one wouldn't be (since you have to copy), but it might be nice to remove the others after N seconds.

philrenaud · 2022-12-09T15:57:45Z

@mikenomitch Added a "Copy to Clipboard" button and set timeout on that particular notification to 30sec.

Changed timeouts for token and policy deletion from 60sec (¯\_(ツ)_/¯) to 5sec

Added quotes to the example CLI command, thanks for spotting that!

ui/app/abilities/token.js

ui/app/components/policy-editor.js

ui/app/controllers/policies/policy.js

ui/app/routes/policies/policy.js

github-actions · 2022-12-14T22:47:11Z

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 9b5c207c7e42874650cfb67c0acb9ea6bc3434ab:

Acceptance | exec: navigating to a task adds its name to the route, chooses an allocation, and assigns a default command

github-actions · 2023-04-15T02:10:03Z

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

philrenaud self-assigned this Nov 30, 2022

philrenaud marked this pull request as draft November 30, 2022 20:09

philrenaud force-pushed the 15423-ui-tokens-crud-for-adminmanager-tokens branch from 028be51 to c4740e1 Compare December 5, 2022 20:53

vercel bot deployed to Preview – nomad-storybook-and-ui December 5, 2022 20:59 View deployment

philrenaud force-pushed the policies-ui branch 2 times, most recently from 92d8cea to 698068b Compare December 6, 2022 15:59

Base automatically changed from policies-ui to main December 6, 2022 17:45

basic-functionality demo for token CRUD

9fa01ac

philrenaud force-pushed the 15423-ui-tokens-crud-for-adminmanager-tokens branch from c4740e1 to 9fa01ac Compare December 6, 2022 18:42

philrenaud linked an issue Dec 6, 2022 that may be closed by this pull request

[ui] Tokens CRUD for admin/manager tokens #15423

Closed

vercel bot deployed to Preview – nomad-storybook-and-ui December 6, 2022 18:48 View deployment

Styling for tokens crud

9d93d54

vercel bot deployed to Preview – nomad-storybook-and-ui December 6, 2022 20:39 View deployment

Tokens crud styles

4b6d04f

vercel bot deployed to Preview – nomad-storybook-and-ui December 7, 2022 17:02 View deployment

Expires, not expiry

57ac662

vercel bot deployed to Preview – nomad-storybook-and-ui December 7, 2022 18:58 View deployment

philrenaud added 2 commits December 7, 2022 14:11

Mobile styles etc

6d4406b

Refresh and redirect rules for policy save and token creation

c8bc0a3

vercel bot deployed to Preview – nomad-storybook-and-ui December 7, 2022 19:39 View deployment

Delete method and associated serializer change

6f80786

vercel bot deployed to Preview – nomad-storybook-and-ui December 7, 2022 21:28 View deployment

Ability-checking for tokens

e5ab544

vercel bot deployed to Preview – nomad-storybook-and-ui December 7, 2022 22:00 View deployment

Update policies acceptance tests to reflect new redirect rules

e33e258

vercel bot deployed to Preview – nomad-storybook-and-ui December 8, 2022 16:53 View deployment

vercel bot deployed to Preview – nomad-storybook-and-ui December 8, 2022 17:07 View deployment

philrenaud commented Dec 8, 2022

View reviewed changes

vercel bot deployed to Preview – nomad-storybook-and-ui December 8, 2022 21:54 View deployment

A couple visual diff snapshots

b72702b

vercel bot deployed to Preview – nomad-storybook-and-ui December 8, 2022 22:04 View deployment

Add and Delete abilities referenced for token operations

396de14

philrenaud force-pushed the 15423-ui-tokens-crud-for-adminmanager-tokens branch from 64f3e29 to 396de14 Compare December 9, 2022 01:50

vercel bot deployed to Preview – nomad-storybook-and-ui December 9, 2022 01:56 View deployment

Changing timeouts and adding a copy to clipboard action

e4fcb4a

vercel bot deployed to Preview – nomad-storybook-and-ui December 9, 2022 16:02 View deployment

ChaiWithJai approved these changes Dec 12, 2022

View reviewed changes

ui/app/abilities/token.js Show resolved Hide resolved

ui/app/components/policy-editor.js Outdated Show resolved Hide resolved

ui/app/controllers/policies/policy.js Outdated Show resolved Hide resolved

ui/app/routes/policies/policy.js Outdated Show resolved Hide resolved

replaced accessor with secret when copying to clipboard

60cfa38

vercel bot deployed to Preview – nomad-storybook-and-ui December 14, 2022 19:58 View deployment

vercel bot deployed to Preview – nomad-storybook-and-ui December 14, 2022 22:06 View deployment

philrenaud force-pushed the 15423-ui-tokens-crud-for-adminmanager-tokens branch from 9b5c207 to 26d854f Compare December 15, 2022 16:11

PR comments addressed

926e9a2

philrenaud force-pushed the 15423-ui-tokens-crud-for-adminmanager-tokens branch from 26d854f to 926e9a2 Compare December 15, 2022 16:12

vercel bot deployed to Preview – nomad-storybook-and-ui December 15, 2022 16:22 View deployment

vercel bot deployed to Preview – nomad-storybook-and-ui December 15, 2022 16:35 View deployment

Simplified error passing for policy editor

0200e2d

philrenaud force-pushed the 15423-ui-tokens-crud-for-adminmanager-tokens branch from 9e06183 to 0200e2d Compare December 15, 2022 17:54

philrenaud changed the title ~~[ui] basic-functionality demo for token CRUD~~ [ui] Component management interface on policy pages Dec 15, 2022

vercel bot deployed to Preview – nomad-storybook-and-ui December 15, 2022 18:01 View deployment

philrenaud changed the title ~~[ui] Component management interface on policy pages~~ [ui] Token management interface on policy pages Dec 15, 2022

philrenaud merged commit c314661 into main Dec 15, 2022

philrenaud deleted the 15423-ui-tokens-crud-for-adminmanager-tokens branch December 15, 2022 18:11

github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ui] Token management interface on policy pages #15435

[ui] Token management interface on policy pages #15435

philrenaud commented Nov 30, 2022 •

edited

Loading

github-actions bot commented Nov 30, 2022 •

edited

Loading

github-actions bot commented Nov 30, 2022 •

edited

Loading

vercel bot commented Dec 6, 2022 •

edited

Loading

philrenaud Dec 8, 2022

mikenomitch commented Dec 8, 2022

philrenaud commented Dec 9, 2022

github-actions bot commented Dec 14, 2022

github-actions bot commented Apr 15, 2023

[ui] Token management interface on policy pages #15435

[ui] Token management interface on policy pages #15435

Conversation

philrenaud commented Nov 30, 2022 • edited Loading

github-actions bot commented Nov 30, 2022 • edited Loading

Ember Asset Size action

github-actions bot commented Nov 30, 2022 • edited Loading

Ember Test Audit comparison

vercel bot commented Dec 6, 2022 • edited Loading

philrenaud Dec 8, 2022

Choose a reason for hiding this comment

mikenomitch commented Dec 8, 2022

philrenaud commented Dec 9, 2022

github-actions bot commented Dec 14, 2022

Ember Test Audit flaky tests

github-actions bot commented Apr 15, 2023

philrenaud commented Nov 30, 2022 •

edited

Loading

github-actions bot commented Nov 30, 2022 •

edited

Loading

github-actions bot commented Nov 30, 2022 •

edited

Loading

vercel bot commented Dec 6, 2022 •

edited

Loading