Support run/plan jobfile via URL location

[nak3]

No description provided.

[nak3]

Suppot jobfile via URL like below:

$  nomad run https://raw.githubusercontent.com/nak3/nomad-playground/master/jobs/nginx.nomad
==> Monitoring evaluation "77543788"
    Evaluation triggered by job "nginx"
    Allocation "4d5af5c7" created: node "d9525e74", group "cache"
    Evaluation status changed: "pending" -> "complete"
==> Evaluation "77543788" finished with status "complete"

[dadgar]

This is cool! I have three requests:

1. Lets use go-getter. This will let us download jobs in a bunch of ways.

2. Lets support nomad validate

3. Add documentation to the commands and website explaining that we support downloading anything in go-getter syntax

[nak3]

Thank you. I added 2) support nomad validate.

But please let me discuss about using go-getter.
Current implentation doesn't download the job, but use HTTP response body like this.

While, if we use go-getter with supported protocol (e.g git/hg), it will not download only one jobfile, but git/hg clone entire repository. So, I feel it is not efficient.

(For example...) If I try to use this git project file with go-getter, it will clone entire git project and specify the one file.

[dadgar]

Hey @nak3,

In the specific case that you give it a git repo, you are correct that it will download the whole thing. However, if you give it the raw url to the file in github like (https://raw.githubusercontent.com/nak3/nomad-playground/master/jobs/nginx.nomad) it will download it using HTTP. By using go-getter you can download the file from more locations which is nice.

We should also refactor the code into a helper so that we don't duplicate everywhere

[nak3]

@dadgar OK, I understand. I update them to use go-getter. Thank you.

[dadgar]

Lets change the name to JobGetter and add a comment on the struct

[dadgar]

Small comments but LGTM

[nak3]

Thank you. I updated them.

[dadgar]

@nak3 Looks like the tests are failing

[nak3]

@dadgar I don't think test was failed due to this PR. I fetched and re-push the PR, and now it passed tests.

[dadgar]

Ah... The travis tests misreport their success right now. Working on that. Here are the raw logs:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/152858750/log.txt

TestPlanCommand_From_URL
TestRunCommand_Fails
....

[nak3]

Oh, sorry. I missed it. Thank you. I updated.

[dadgar]

Awesome thank you so much!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.