-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mount propagation to protobuf definition of mounts #15096
Add mount propagation to protobuf definition of mounts #15096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @stswidwinski 🙂
Would you mind add tests for this change? I think adding PropagationMode
to TestTaskConfigRoundTrip
may be a good one, but feel free to add other tests if you see fit.
We also require contributors to sing our CLA before merging work, so you could you this as well?
Sure thing! I'll do that on Monday -- I was looking for related roundtrip tests but didn't find them before. Quite embarassing that they are exactly where i should've expected them. Thanks for the pointer!
Re. CLA -- it might be one or two extra days on my end. Sorry about that.
…On Fri, Nov 4, 2022, 5:46 PM Luiz Aoqui ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thanks for the contribution @stswidwinski
<https://github.com/stswidwinski> 🙂
Would you mind add tests for this change? I think adding PropagationMode
to TestTaskConfigRoundTrip
<https://github.com/hashicorp/nomad/blob/v1.4.2/plugins/drivers/utils_test.go#L77-L82>
may be a good one, but feel free to add other tests if you see fit.
We also require contributors to sing our CLA before merging work, so you
could you this as well?
—
Reply to this email directly, view it on GitHub
<#15096 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECDANBOHQWE5B26U6TGRO3WGV73VANCNFSM6AAAAAARUDHOR4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The CLA has been signed. Thanks for your patience @lgfa29 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a commit to add a changelog entry for this. Thank you for the contribution and for taking care of the CLA 🙂
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
A simple fix for #15014 and the related hashicorp/nomad-driver-podman#192.
Tests pass for the
drivers
package.