Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 advertise addresses #1465

Merged
merged 2 commits into from
Jul 25, 2016
Merged

Fix IPv6 advertise addresses #1465

merged 2 commits into from
Jul 25, 2016

Conversation

42wim
Copy link
Contributor

@42wim 42wim commented Jul 25, 2016

Fixes #1318 by making sure it uses the correct syntax for IPv6 addresses.
Adds 2 helper functions

diptanu
diptanu reviewed Jul 25, 2016
View reviewed changes
command/agent/util.go
}

// joinIPPort joins ip and port correctly for IPv4 (ip:port) or IPv6 ([ip]:port)
func joinIPPort(ip string, port int) string {
Copy link
Contributor

@diptanu diptanu Jul 25, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use https://golang.org/pkg/net/#JoinHostPort ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I didn't think of it :-)
That's the better option, no extra helpers needed (but strconv.Itoa(everyport).
Should I rebase using JoinHostPort?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Just update your branch with the JoinHostPort, and I think the PR would automatically get updated.

@diptanu
Copy link
Contributor

diptanu commented Jul 25, 2016

@42wim Thanks for the PR! I have made one comment. Once you update the PR, we can merge this.

@42wim
Copy link
Contributor Author

42wim commented Jul 25, 2016

Ok, I updated it (without rebase).
Unrelated but I saw that the one function ipOfDevice in command/agent/util.go isn't used anywhere, that file could be removed.

@42wim
Copy link
Contributor Author

42wim commented Jul 25, 2016

This also seems to fix #1349

@dadgar
Copy link
Contributor

dadgar commented Jul 25, 2016

Nice thanks!

@dadgar dadgar merged commit d322eb5 into hashicorp:master Jul 25, 2016
@dadgar dadgar mentioned this pull request Jul 25, 2016
Closed
@The-Loeki The-Loeki mentioned this pull request Jul 26, 2016
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@42wim @diptanu @dadgar