-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Namespace, Job and Group to envoy stats #14311
Conversation
Thanks for the PR @jorgemarey! I've left some comments for discussion. |
Thanks @tgross for taking the time to review this. I'll update the PR with the suggested changes as soon as I can! |
bd097a7
to
fa5aba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jorgemarey! Thanks for your patience on this. The updates you've done here LGTM 👍 . I'm going to push a changelog entry on top of the PR, rebase on main, and fix the merge conflicts and then we'll get this merged.
fa5aba3
to
c2b3217
Compare
Deployment failed with the following error:
|
Merged! This will ship in Nomad 1.4.0 |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds more tags (nomad namespace, job and group) to the envoy stats tags.
It's useful when performing scaling based on envoy request being able to filter the service by nomad job/group.
Follows the work done in #12543