Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set osusergo build tag by default #14248

Merged
merged 1 commit into from
Aug 24, 2022
Merged

build: set osusergo build tag by default #14248

merged 1 commit into from
Aug 24, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Aug 23, 2022 •
edited
Loading

This PR activates the osuergo build tag in GNUMakefile. This forces the os/user
package to be compiled without CGO. Doing so seems to resolve a race condition
in getpwnam_r that causes alloc creation to hang or panic on user.Lookup("nobody").

Fixes: #14235
Fixes: #14217

@shoenig
build: set osusergo build tag by default
c4ec30a 
This PR activates the osuergo build tag in GNUMakefile. This forces the os/user
package to be compiled without CGO. Doing so seems to resolve a race condition
in getpwnam_r that causes alloc creation to hang or panic on `user.Lookup("nobody")`.
@shoenig shoenig marked this pull request as ready for review August 23, 2022 21:24
lgfa29
lgfa29 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL. Thanks!

@lgfa29
Copy link
Contributor

lgfa29 commented Aug 24, 2022

Is this an issue in previous versions as well? How far back should we backport it? 🤔

DerekStrickland
DerekStrickland approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 TIL

tgross
tgross approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross
Copy link
Member

tgross commented Aug 24, 2022

Is this an issue in previous versions as well? How far back should we backport it?

We saw it in 1.2.6 (ref #12342) but didn't have a repro at the time. As far as I can tell the problem is inherent to the design (concurrent lookups b/c we start tasks concurrently), not to a specific version. We should probably backport to all supported versions.

@shoenig shoenig added this to the 1.3.4 milestone Aug 24, 2022
@shoenig shoenig added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Aug 24, 2022
@shoenig shoenig merged commit 2d425bf into main Aug 24, 2022
@shoenig shoenig deleted the b-set-osusergo branch August 24, 2022 13:11
This was referenced Aug 24, 2022
Merged
Merged
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@DerekStrickland DerekStrickland DerekStrickland approved these changes

@lgfa29 lgfa29 lgfa29 approved these changes

Assignees
No one assigned
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

nomad fails to place second allocation in basic job panic from dropDirPermissions
4 participants
@shoenig @lgfa29 @tgross @DerekStrickland