Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Policies UI #13976

Merged
merged 37 commits into from
Dec 6, 2022
Merged

[ui] Policies UI #13976

merged 37 commits into from
Dec 6, 2022

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Aug 3, 2022

Adds a new section to the UI sidebar for Policies, restricted to Management token users.

This interface can be used to view, create, update or delete existing policies. With time, we can expand this to include token management and other ACL / role management for cluster users.

image

image

@philrenaud philrenaud mentioned this pull request Aug 3, 2022
12 tasks
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Ember Asset Size action

As of 698068b

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +22.6 kB +3.18 kB
nomad-ui.css +377 B +82 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Aug 3, 2022

Ember Test Audit comparison

main 698068b change
passes 1435 1442 +7
failures 0 0 0
flaky 0 0 0
duration 10m 45s 140ms 10m 27s 710ms -17s 430ms

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on bfe1a60:

  • Integration | Utility | exec-command-editor-xterm-adapter: it can wrap to a previous line while backspacing

@philrenaud
Copy link
Contributor Author

self-reminder to update https://discuss.hashicorp.com/t/can-we-create-acl-policy-tokens-via-web-ui/15503 and similar when this is complete

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small piece of feedback about cleaning up logic after your tests run.

ui/app/routes/policies.js Outdated Show resolved Hide resolved
ui/app/routes/policies/new.js Show resolved Hide resolved
ui/app/routes/policies/policy.js Show resolved Hide resolved
ui/tests/acceptance/policies-test.js Show resolved Hide resolved
@mikenomitch
Copy link
Contributor

Some notes when testing:

  • We should add variables policy example to the boilerplate policy
  • I think we talked about this before but can we get HCL highlighting? If not or if its big scope creep, nbd leaving it.
  • If you save an invalid policy, the UI throws an error which has some helpful info in it, but it also exposes Ember Data details to the end user. Ideally just the more message is passed up to the user.

LGTM otherwise and lol @ Chesterton's Style Property.

@philrenaud
Copy link
Contributor Author

@mikenomitch it's not quite HCL/HCL2 highlighting, but syntax highlight mode = ruby does a pretty good impression!
image

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nomad-storybook-and-ui ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 6, 2022 at 4:12PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
nomad ⬜️ Ignored (Inspect) Dec 6, 2022 at 4:12PM (UTC)

@chrisvanmeer
Copy link
Contributor

@philrenaud Can I ask if the Consul and Vault deeplinks in the top menu bar are also present in the new v1.5.0? I upgraded but cannot see those links in the menu bar next to Documentation.

@philrenaud
Copy link
Contributor Author

Hi @chrisvanmeer ! I am able to see Consul and Vault deeplinks with the following config rules:

acl {
  enabled = true
}

...
...
...

ui {
  consul {
    ui_url = "http://localhost:8500/ui"
  }

  vault {
    ui_url = "https://vault.example.com:8200/ui"
  }

  enabled = true

  label {
    text             = "Miami Datacenter"
    background_color = "palegreen"
    text_color       = "black"
  }
}

image

Feel free to send over some of your config.ui HCL and I'll see if I spot anything!

@chrisvanmeer
Copy link
Contributor

Hey @philrenaud thanks for the reply! I totally overlooked the ui block in the release notes. My bad. I applied the block you provided and it works like advertised :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants