-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Policies UI #13976
[ui] Policies UI #13976
Conversation
Ember Asset Size actionAs of 698068b Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on bfe1a60:
|
self-reminder to update https://discuss.hashicorp.com/t/can-we-create-acl-policy-tokens-via-web-ui/15503 and similar when this is complete |
bfe1a60
to
e742e41
Compare
…oving save into the policy editor itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One small piece of feedback about cleaning up logic after your tests run.
Some notes when testing:
LGTM otherwise and lol @ Chesterton's Style Property. |
@mikenomitch it's not quite HCL/HCL2 highlighting, but syntax highlight mode = ruby does a pretty good impression! |
c11ba60
to
92d8cea
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
92d8cea
to
698068b
Compare
@philrenaud Can I ask if the Consul and Vault deeplinks in the top menu bar are also present in the new v1.5.0? I upgraded but cannot see those links in the menu bar next to Documentation. |
Hi @chrisvanmeer ! I am able to see Consul and Vault deeplinks with the following config rules:
Feel free to send over some of your config.ui HCL and I'll see if I spot anything! |
Hey @philrenaud thanks for the reply! I totally overlooked the ui block in the release notes. My bad. I applied the block you provided and it works like advertised :) |
Adds a new section to the UI sidebar for Policies, restricted to Management token users.
This interface can be used to view, create, update or delete existing policies. With time, we can expand this to include token management and other ACL / role management for cluster users.