-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix zero memory utilization bug on systems using cgroups v2 #13670
Conversation
Ember Asset Size actionAs of d1e14f1 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
6794c5e
to
a31e350
Compare
This PR fixes a bug where allocation memory usage is always zero on Linux systems where the kernel is configured to use cgroups v2.
a31e350
to
17000ba
Compare
Gave this a shot but I don't know how to make this test happy |
Thanks @shoenig , digging into that test now |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
A quick band-aid fix for #13023. On systems using cgroups v2, the
MemoryStats
struct no longer reports.RSS
, but rather.Usage
. Kind of just assuming they mean the same thing.The fix here is to just check if
.Usage
exists and if so use that, otherwise fallback to the.RSS
field.@philrenaud @ChaiWithJai
Fixes #13023