Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query for leader in operator debug command #13472

Merged
merged 2 commits into from
Jul 6, 2022
Merged

query for leader in operator debug command #13472

merged 2 commits into from
Jul 6, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 23, 2022 •
edited
Loading

The operator debug command doesn't output the leader anywhere in the
output, which adds extra burden to offline debugging (away from an
ongoing incident where you can simply check manually). Query the
/v1/status/leader API but degrade gracefully.

@tgross tgross force-pushed the operator-debug-peers branch from fa92cb4 to 71d1038 Compare June 24, 2022 20:50
@tgross tgross changed the title query raft peers in operator debug command query raft leader in operator debug command Jun 24, 2022
@tgross tgross force-pushed the operator-debug-peers branch from 71d1038 to c801205 Compare June 27, 2022 14:25
@tgross tgross changed the title query raft leader in operator debug command query for leader in operator debug command Jun 27, 2022
@tgross tgross requested review from davemay99 and jazzyfresh June 27, 2022 14:26
@tgross tgross marked this pull request as ready for review June 27, 2022 14:26
@tgross tgross added this to the 1.3.x milestone Jun 28, 2022
jrasell
jrasell approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog entry, otherwise LGTM!

tgross added 2 commits July 6, 2022 10:23
@tgross
query for leader in operator debug command
e8be0a4 
The `operator debug` command doesn't output the leader anywhere in the
output, which adds extra burden to offline debugging (away from an
ongoing incident where you can simply check manually). Query the
`/v1/status/leader` API but degrade gracefully.
@tgross
changelog entry
ca6d16d
@tgross tgross force-pushed the operator-debug-peers branch from c801205 to ca6d16d Compare July 6, 2022 14:24
@tgross tgross modified the milestones: 1.3.x, 1.3.2 Jul 6, 2022
@tgross tgross merged commit ad4efce into main Jul 6, 2022
@tgross tgross deleted the operator-debug-peers branch July 6, 2022 14:57
@tgross tgross modified the milestones: 1.3.2, 1.3.4 Aug 23, 2022
@tgross tgross added the backport/1.3.x backport to 1.3.x release line label Aug 23, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Aug 23, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

@davemay99 davemay99 Awaiting requested review from davemay99

@jazzyfresh jazzyfresh Awaiting requested review from jazzyfresh

Assignees
No one assigned
Labels
backport/1.3.x backport to 1.3.x release line theme/cli
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross @jrasell