Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cni: add loopback to linux bridge #13428

Merged
merged 2 commits into from
Jun 20, 2022
Merged

cni: add loopback to linux bridge #13428

merged 2 commits into from
Jun 20, 2022

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Jun 19, 2022 •
edited
Loading

CNI changed how to bring up the interface in v0.2.0.
Support was moved to a new loopback plugin.

containernetworking/cni#121

Fixes #10014

@h0tw1r3 h0tw1r3 changed the title cni: add loopback to linux bridge (#10014) cni: add loopback to linux bridge Jun 19, 2022
@h0tw1r3
cni: add loopback to linux bridge
d7677af 
CNI changed how to bring up the interface in v0.2.0.
Support was moved to a new loopback plugin.

containernetworking/cni#121

Fixes hashicorp#10014
@h0tw1r3 h0tw1r3 force-pushed the fix-10014-bridge-loopback branch from 24b9238 to d7677af Compare June 19, 2022 15:12
@tgross tgross self-requested a review June 20, 2022 14:59
tgross
tgross approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this out locally and LGTM! Thanks @h0tw1r3!

I've added a changelog entry and this will get shipped in the next release of Nomad (1.3.2) and get backported to previous versions.

@tgross tgross added this to the 1.3.2 milestone Jun 20, 2022
@tgross tgross added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Jun 20, 2022
@tgross tgross merged commit eff2c01 into hashicorp:main Jun 20, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 20, 2022
Merged
@tgross tgross mentioned this pull request Jun 20, 2022
Closed
This was referenced Jun 20, 2022
Merged
Merged
@h0tw1r3 h0tw1r3 deleted the fix-10014-bridge-loopback branch June 21, 2022 14:58
@primeos-work primeos-work mentioned this pull request Sep 20, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
1.3.2
2 participants
@h0tw1r3 @tgross