CSI volume API returns invalid/no JSON if volume doesn't exist

[rbastiaans-tc]

Nomad version

Nomad v1.3.0 (52e95d64113e01be05d585d8b4c07f6f19efebbc)

Operating system and Environment details

Debian 10 Buster

Issue

The Nomad API for: Read Volume: returns no/invalid JSON for volumes that don't exist

• https://www.nomadproject.io/api-docs/volumes#read-volume
• GET /v1/volume/csi/:volume_id

The docs state that it produces: application/json

Reproduction steps

$ curl -H "Accept: application/json" nomad.service.consul:4646/v1/volume/csi/nonexistant
volume not found
$ curl -s -H "Accept: application/json" nomad.service.consul:4646/v1/volume/csi/nonexistant | jq
parse error: Invalid numeric literal at line 1, column 7
$ curl -s -H "Accept: application/json" nomad.service.consul:4646/v1/volume/csi/nonexistant | python -m json.tool
No JSON object could be decoded

Expected Result

Some valid JSON data with the error, something like this:

• { 'status': 'volume not found' }

Actual Result

Regular text status response:

• volume not found

Job file (if appropriate)

Nomad Server logs (if appropriate)

Nomad Client logs (if appropriate)

[tgross]

Hi @rbastiaans-tc! This is an unfortunate misfeature across the entire Nomad HTTP API. See also #8236. We'll need to break backwards compatibility to fix it, so we need to go thru a design effort and then a deprecation period first. I'm going to mark this issue for roadmapping until we have an issue open to go thru that API change work.

Thanks for opening this issue!