Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chronological most-recent evals by default #12847

Merged
merged 3 commits into from
May 5, 2022
Merged

Chronological most-recent evals by default #12847

merged 3 commits into from
May 5, 2022

Conversation

philrenaud
Copy link
Contributor

Resolves #12820

@philrenaud philrenaud self-assigned this May 2, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2022 •
edited
Loading

Ember Asset Size action

As of 757f879

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +11 B +5 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented May 2, 2022 •
edited
Loading

Ember Test Audit comparison

main 757f879 change
passes 1287 1287 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented May 2, 2022

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: facet Status | the Status facet filters the allocations list by Status

@philrenaud philrenaud marked this pull request as ready for review May 2, 2022 19:14
ChaiWithJai
ChaiWithJai approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philrenaud philrenaud merged commit f1fdca5 into main May 5, 2022
@philrenaud philrenaud deleted the 12820-sort-evaluation-list-by-create-date branch May 5, 2022 20:11
@lgfa29 lgfa29 added the backport/1.3.x backport to 1.3.x release line label May 5, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request May 5, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

Assignees

@philrenaud philrenaud

Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort evaluation list by create date
3 participants
@philrenaud @ChaiWithJai @lgfa29