Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #12592 #12593

Merged
merged 2 commits into from
Apr 18, 2022
Merged

fix #12592 #12593

merged 2 commits into from
Apr 18, 2022

Conversation

chavacava
Copy link
Contributor

fix #12592 by changing a by-value method receiver into a pointer receiver

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @chavacava!

I took a look at where this was introduced (ref 6a6547b) and it looks like it the consequence of this bug is that we don't properly reset the blocking timeout when we're retrying blocking queries from the client. This could result in a blocking query running longer than expected. I've added a changelog entry. We'll ship this in Nomad 1.3.0 and backport it to 1.2.x and 1.1.x.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line type/bug
Projects
Development

Successfully merging this pull request may close these issues.

suspicious assignment to a by-value method receiver
3 participants