template: disallow writeToFile by default
#12312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
f-writeToFile
branch
from
a9833ce
to
31ae1ff
Compare
schmichael
force-pushed
the
f-writeToFile
branch
from
31ae1ff
to
c768060
Compare
This was referenced Mar 28, 2022
schmichael
force-pushed
the
f-writeToFile
branch
from
c768060
to
65958e5
Compare
Resolves #12095 by WONTFIXing it. This approach disables `writeToFile` as it allows arbitrary host filesystem writes and is only a small quality of life improvement over multiple `template` stanzas. This approach has the significant downside of leaving people who have altered their `template.function_denylist` *still vulnerable!* I added an upgrade note, but we should have implemented the denylist as a `map[string]bool` so that new funcs could be denied without overriding custom configurations. This PR also includes a bug fix that broke enabling all consul-template funcs. We repeatedly failed to differentiate between a nil (unset) denylist and an empty (allow all) one.
schmichael
force-pushed
the
f-writeToFile
branch
from
65958e5
to
f87ec7e
Compare
Review notes from @lgfa29 Co-authored-by: Luiz Aoqui <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12095 by WONTFIXing it.
This approach disables
writeToFileas it allows arbitrary hostfilesystem writes and is only a small quality of life improvement over
multiple
templatestanzas.This approach has the significant downside of leaving people who have
altered their
template.function_denyliststill vulnerable! I addedan upgrade note, but we should have implemented the denylist as a
map[string]boolso that new funcs could be denied without overridingcustom configurations.
This PR also includes a bug fix that broke enabling all consul-template
funcs. We repeatedly failed to differentiate between a nil (unset)
denylist and an empty (allow all) one.