-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to namespaces #12138
Add metadata to namespaces #12138
Conversation
Hi @jorgemarey and thanks for raising this PR. We will try and get an initial review done promptly to provide any feedback. |
Thanks for the PR @jorgemarey! I updated some more docs and the CLI output. Mind giving it one last look @jrasell? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jorgemarey and thanks again, this looks great!
I wonder if it would be possible to add or modify a namespace test to ensure the meta field is present as expected? /nomad/namespace_endpoint_test.go
or /command/agent/namespace_endpoint_test.go
perhaps?
If you could add a changelog entry that would be wonderful, this document details the process.
Hi @jrasell I added a meta value to the mock namespace. Is that enought? I also created the changelog file. |
Yeah that is a great idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jorgemarey!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jrasell and @jorgemarey!
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds a metadata field to the namespace objects allowing users to attach custom data to namespaces.
Fixes #9631