Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: tolerate missing plugins on job delete #12114

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Feb 23, 2022

Fixes #11758

If a plugin job fails before successfully fingerprinting the plugins,
the plugin will not exist when we try to delete the job. Tolerate
missing plugins.


$ nomad job stop -purge badplugin
==> 2022-02-23T16:02:06-05:00: Monitoring evaluation "c3b163b5"
    2022-02-23T16:02:06-05:00: Evaluation triggered by job "badplugin"
==> 2022-02-23T16:02:07-05:00: Monitoring evaluation "c3b163b5"
    2022-02-23T16:02:07-05:00: Evaluation status changed: "pending" -> "complete"
==> 2022-02-23T16:02:07-05:00: Evaluation "c3b163b5" finished with status "complete"

$ nomad job status badplugin
No job(s) with prefix or id "badplugin" found

If a plugin job fails before successfully fingerprinting the plugins,
the plugin will not exist when we try to delete the job. Tolerate
missing plugins.
@tgross tgross force-pushed the csi-tolerate-nil-plugin-on-job-delete branch from 78c4694 to 848c4b0 Compare February 23, 2022 21:07
@vercel vercel bot temporarily deployed to Preview – nomad February 23, 2022 21:07 Inactive
@tgross tgross added this to the 1.3.0 milestone Feb 23, 2022
@tgross tgross changed the title csi: tolerate missing plugins on job delete CSI: tolerate missing plugins on job delete Feb 23, 2022
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line theme/storage type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to normally stop and purge system job with csi plugin
4 participants