CSI: volume cli prefix matching should accept exact match #12051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `volume detach`, `volume deregister`, and `volume status` commands accept a prefix argument for the volume ID. Update the behavior on exact matches so that if there is more than one volume that matches the prefix, we should only return an error if one of the volume IDs is not an exact match. Otherwise we won't be able to use these commands at all on those volumes. This also makes the behavior of these commands consistent with `job stop`.
tgross
force-pushed
the
csi-cli-prefix-matching
branch
from
006c498
to
1c5597a
Compare
lgfa29
approved these changes
Feb 10, 2022
| if len(vols) == 0 { | ||
| c.Ui.Error(fmt.Sprintf("No volumes(s) with prefix or ID %q found", volID)) | ||
| return 1 | ||
| } | ||
| if len(vols) > 1 { | ||
| if (volID != vols[0].ID) || (c.allNamespaces() && vols[0].ID == vols[1].ID) { |
There was a problem hiding this comment.
Just checking my understanding of the state store, when looking by ID prefix, vols would be sorted by prefix length, so if the first element is not an exact match, we don't need to check the rest because it would be a longer value. Is this right? 😅
There was a problem hiding this comment.
Exactly. This property arises from go-immutable-radix.
lgfa29
added
backport/1.1.x
This was referenced Apr 19, 2022
Merged
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12005
The
volume detach,volume deregister, andvolume statuscommandsaccept a prefix argument for the volume ID. Update the behavior on
exact matches so that if there is more than one volume that matches
the prefix, we should only return an error if one of the volume IDs is
not an exact match. Otherwise we won't be able to use these commands
at all on those volumes. This also makes the behavior of these commands
consistent with
job stop.