Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: merge ReservableCores in clientConfig #12044

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

aholyoake-bc
Copy link
Contributor

@aholyoake-bc aholyoake-bc commented Feb 10, 2022

Fixes: #12043

Note: There is an inconsistency throughout the codebase regarding Reserveable and Reservable

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 10, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross
Copy link
Member

tgross commented Feb 15, 2022

Thanks @aholyoake-bc! For some reason CircleCI isn't running on this PR, but LGTM. I'll keep an eye on CI once it gets merged and add a commit for the changelog.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line
Projects
Development

Successfully merging this pull request may close these issues.

reservable_cores is not respected
4 participants